You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional Constraint for no_of_pins
An extra validation has been added to ensure that the parameter no_of_pins does not exceed the maximum allowable value, defined as SOC_LEDC_CHANNEL_NUM for better data integrity and system stability.
Reorganized Order of Checks and Code Clarity
The sequence of examination to check if no_of_pins equals 0 has been moved prior to the step to enable the peripheral module resulting in more efficient troubleshooting and execution. The related code has also been restructured for better understandability, leading to easier maintenance.
Uninterrupted Enabling Process
Despite the assertion and condition checks' adjustments, the process to enable the peripheral module stays the same and is still triggered after these checks are completed, ensuring smooth operation.
The reason will be displayed to describe this comment to others. Learn more.
The definition for PWM_CHANNEL_NUM_MAX in Sming/Arch/Esp32/Components/driver/include/pwm.h should always be obtained from the IDF. We cannot make assumptions, please amend to:
include <soc/soc_caps.h>
#define PWM_CHANNEL_NUM_MAX SOC_LEDC_CHANNEL_NUM
This PR updates the Sming coding style documentation as discussed in #2898 (comment) and #2904 (comment).
Sming requires version 8 which is generally no longer available in the standard repositories for recent GNU/Linux distributions. Different versions of clang-format produce different output with the same configuration. This is such a common problem that a kind soul has provided standalone builds here https://github.com/muttleyxd/clang-tools-static-binaries/releases.
The default name of the clang-format executable has been changed to `clang-format-8`. This is because `clang-format` is now very unlikely to be the default installed version, and so avoids the subtle issues with running the wrong version.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if called with more than the supported channels (depending on the SoC), the constructor would silently fail, yielding a misleading error message.